-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[flang] Adding a couple of tests to the alias analysis #125917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me be conservative here for now, thanks!
@@ -47,6 +47,14 @@ | |||
// CHECK-DAG: arg2.load#0 <-> arg2.addr#0: MustAlias | |||
// CHECK-DAG: boxp1.addr#0 <-> arg2.addr#0: MayAlias | |||
|
|||
// TODO: Can the address in a pointer alias the address of a pointer, even when the | |||
// pointer has no box. Should this be NoAlias? | |||
// T3: CHECK-DAG: p1.addr#0 <-> p1.tgt#0: MayAlias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want "T3" and "T4" to appear in comments when landing upstream?
I wrote those just to guide discussion of #117785.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot no. I missed that. I will post a new review.
To establish a baseline for new tests mentioned in llvm#117785, adding them here independently.
To establish a baseline for new tests mentioned in #117785, adding them here independently.